Changes for BraidingTensor on SumSpace#51
Draft
kshyatt wants to merge 1 commit intoQuantumKitHub:mainfrom
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #51 +/- ##
==========================================
- Coverage 56.27% 51.98% -4.30%
==========================================
Files 20 19 -1
Lines 1434 1437 +3
==========================================
- Hits 807 747 -60
- Misses 627 690 +63 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lkdvos
reviewed
Apr 28, 2026
| end | ||
|
|
||
| function TK.braidingtensortype(::Type{SumSpace{S}}, ::Type{TorA}) where {S, TorA} | ||
| return BraidingTensor{scalartype(TorA), S, similarstoragetype(TorA)} |
Member
There was a problem hiding this comment.
Do you know where this is necessary? I might be misremembering, but I thought spacetype already outputs S, and never SumSpace{S}
Member
Author
There was a problem hiding this comment.
It's needed for MPSKit :(. Without it, the cuda/operators tests all fail, I'll try to get a more detailed trace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.